Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/vault client auth #22

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Refactor/vault client auth #22

wants to merge 4 commits into from

Conversation

MatteoVoges
Copy link
Member

Proposed Changes

  • improved error handling for different auth types
  • added comments
  • sets VAULT_SKIP_VERIFY to False as default --> you have to specify CACERT or CAPATH by default.

@MatteoVoges MatteoVoges added the enhancement New feature or request label Oct 4, 2023
@MatteoVoges MatteoVoges requested a review from jrod-97 October 4, 2023 14:30
@MatteoVoges MatteoVoges self-assigned this Oct 4, 2023
@MatteoVoges MatteoVoges force-pushed the refactor/vault-client-auth branch 2 times, most recently from 666e353 to ee33772 Compare October 5, 2023 13:07
@MatteoVoges MatteoVoges force-pushed the refactor/vault-client-auth branch from ee33772 to ca8ef90 Compare October 5, 2023 13:23
@MatteoVoges MatteoVoges added the kapicorp-PR open kapicorp PR label Oct 30, 2023
@github-actions github-actions bot added the Stale label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrod-97 jrod-97 Awaiting requested review from jrod-97

At least 1 approving review is required to merge this pull request.

Assignees

@MatteoVoges MatteoVoges

Labels
enhancement New feature or request kapicorp-PR open kapicorp PR Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MatteoVoges