Review/nav 87 include refactorings from nav 83 review #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests and maybe performance improvements coming soon.
…two separate generators.
- Allows search for STARTS_WITH, ENDS_WITH, CONTAINS and EXACT. - Duplicate search keys are not yet supported in the index.
- Adjust test builder accordingly.
- Implementation of the public transit service interface. - Apply visitor pattern to iterate through legs. - Split service into schedule info and connection routing interface, supporting interface segregation.
- Add trip to stop and fix recursion. - Extend visitor pattern. - Rename isoline to getIsolines.
- Setup dependency injection. - Setup logging and dependencies. - Add DTO mapper and map objects in controllers. - Add application.properties for configuration of the service. - Rename model to dto.
- A walk from a location to a stop, the first leg of a connection. - A walk from a stop to a location, the last leg of a connection. - A walk between two locations, the only leg of a connection.
… generate transfers.
…lementation-based-on-gtfs-and-raptor' into NAV-84-Allow-querying-connections-from-location-or-stop-id-in-REST-API
…quest parameters.
…s-from-location-or-stop-id-in-REST-API Nav 84 allow querying connections from location or stop id in rest api
- Adjust spring service. - Update type mapper and dto mapper.
…o feature/NAV-83-reduce-gtfs-switzerland-to-trams-in-zurich
…ervice REFACTOR: NAV-81 - Move spatial index from GTFS to service
…fs-and-raptor' into feature/NAV-83-reduce-gtfs-switzerland-to-trams-in-zurich
…acity of node internal data structures
Nav 86 suffix trie
…fs-and-raptor' into NAV-87-Add-support-to-route-from-parent-stop-to-parent-stop # Conflicts: # src/main/java/ch/naviqore/service/impl/PublicTransitServiceImpl.java
…ic class inside PublicTransitService.
…erator Interface.
…stop, coordinate-stop, coordinate-coordinate)
… (including handicap time)
…nection from Initial Leg.
…stop' into review/NAV-87-include-refactorings-fromNAV-83-review # Conflicts: # src/main/java/ch/naviqore/service/impl/PublicTransitServiceImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time the correct branch