feat: Dask multiple partitions #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Sep 10, 2024
| @@ -79,7 +79,9 @@ def filter( | |||
| and isinstance(predicates[0], list) | |||
| and all(isinstance(x, bool) for x in predicates[0]) | |||
| ): | |||
| msg = "Filtering with boolean mask is not supported for `DaskLazyFrame`" | |||
| msg = ( | |||
| "`LazyFrame.filter` is not supported for Dask backend with boolean masks." | |||
There was a problem hiding this comment.
Aligns error message with others. User should not really know about DaskLazyFrame
|
CI Failure is due to a |
MarcoGorelli
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
thanks @FBruzzesi ! test suite time stays about 2 minutes so it's probably ok to test both npartitions=1 and npartitions=2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
npartitions=2#872Checklist
If you have comments or can explain your changes, please do so below.