Add docstring for Expr.min() #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
reviewed
May 6, 2024
There was a problem hiding this comment.
Thanks @shriyakalakata , this looks great!
I think there's just some extra whitespace you need to remove
Can you run
pytest narwhals --doctest-modules
and check it passes please?
Done! |
MarcoGorelli
approved these changes
May 6, 2024
There was a problem hiding this comment.
amazing, thanks @shriyakalakata !
regarding style-guide - currently there's just the pre-commit checks to follow, see #90 - fancy submitting a PR for that, if it interests you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #71
Screenshot:
