Added docstring for Expr.is_null #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
reviewed
May 6, 2024
narwhals/expression.py
Outdated
|
|
||
| >>> def func(df_any): | ||
| ... df = nw.from_native(df_any) | ||
| ... df = df.with_columns(nw.all().is_null()) # nan != null for polars |
There was a problem hiding this comment.
how about showing:
... df = df.with_columns(
... a_is_null = nw.col('a').is_null(),
... b_is_null = nw.col('b').is_null(),
... ), so that the output is easier to reason about?
There was a problem hiding this comment.
Yeah, that makes more sense. I'll add it in the next pull request
There was a problem hiding this comment.
thanks! can you add it to this one please? if you make your change, add and commit them, and push them to this branch, then this pull request will be automatically updated
There was a problem hiding this comment.
Okay, I've updated the branch now
MarcoGorelli
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.