Make Ibis comparison friendlier #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a fan of Ibis, and I've been made aware that my initial comparison didn't go down very well with them.
In my head, it was intended more of as a "here's justification for why I wanted to make yet another tool, where Ibis wouldn't be sufficient", but I understand that that's not the way it came across, and I'm sorry.
I've tried making the comparison fairer and friendlier - tagging @lostmygithubaccount in case you have comments. I'm a fan of Ibis and would like to be on good terms 🤗 Hopefully this strikes the right balance?