-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add drop_nulls
, fill_null
, and filter
Spark Expressions
#1802
Open
lucas-nelson-uiuc
wants to merge
17
commits into
narwhals-dev:main
Choose a base branch
from
lucas-nelson-uiuc:spark-expr-high-priority
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add drop_nulls
, fill_null
, and filter
Spark Expressions
#1802
lucas-nelson-uiuc
wants to merge
17
commits into
narwhals-dev:main
from
lucas-nelson-uiuc:spark-expr-high-priority
+91
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
thanks for your pr, really appreciate it! to be honest i'm not totally sold on having expressions which change length but don't aggregate be supported in the lazy api we may be able to support them, but only if they're followed by an aggregations, so they're kinda like the equivalent of sql's
Will get back to you on this anyway, but for now we may need to punt on these methods, really sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below
Added support for the following methods - made sure to remove all pyspark constructor checks in the main test suite:
drop_nulls
fill_null
nw.Expr.fill_null
are "forward" and "backward" - are there plans to add more strategies (possibly in v2)?filter
(work in progress)pyspark.sql.function.filter
expects the predicate to return aColumn
; however, it raises an error since_from_call
returnsSparkLikeExpr
).