docs: Removed class, added polars to the table, str.head and str.tail are a… #1801
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Hey @marvinl803 thanks for your contribution! I left a comment regarding the inclusion of polars in the tables :)
| @@ -49,12 +49,15 @@ class Backend(NamedTuple): | |||
| Backend(name="duckdb", module="_duckdb", type_=BackendType.LAZY), | |||
| Backend(name="pandas-like", module="_pandas_like", type_=BackendType.EAGER), | |||
| Backend(name="spark-like", module="_spark_like", type_=BackendType.LAZY), | |||
| Backend(name="polars", module="_polars", type_=BackendType.EAGER), | |||
There was a problem hiding this comment.
I assume you are referring to #1789 comment. However, this would not render as expected since our polars implementation mostly call polars methods dynamically. Since we follow a subset of the polars API, everything should be flagged as green for a potential polars column in each table.
Thank you, I'll take a look at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Expr.str.head/Expr.str.tail#1789Checklist
If you have comments or can explain your changes, please do so below
I removed the class column from the api-completeness table. Also added polars to the tables and marked Expr.str.head / Expr.str.tail as checked. If there is any issues or corrections needed please let me know, thank you!