Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DuckDB date #1798

Merged
merged 2 commits into from
Jan 11, 2025
Merged

feat: DuckDB date #1798

merged 2 commits into from
Jan 11, 2025

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Jan 11, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Jan 11, 2025
MarcoGorelli
MarcoGorelli approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 amazing, doing all the dt namespace - thanks @raisadz !

@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 11, 2025 16:47
@MarcoGorelli MarcoGorelli merged commit 5981743 into narwhals-dev:main Jan 11, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raisadz @MarcoGorelli