Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Filter left join warning #1753

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore: Filter left join warning #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ filterwarnings = [
'ignore:.*You are using pyarrow version',
# This warning was temporarily raised by pandas but then reverted.
'ignore:.*Passing a BlockManager to DataFrame:DeprecationWarning',
# This warning was temporarily raised by Polars but then reverted.
'ignore:.*The default coalesce behavior of left join will change:DeprecationWarning',
]
xfail_strict = true
markers = ["slow: marks tests as slow (deselect with '-m \"not slow\"')"]
Expand Down
3 changes: 0 additions & 3 deletions tests/frame/join_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ def test_join_not_implemented(constructor: Constructor, how: str) -> None:
df.join(df, left_on="antananarivo", right_on="antananarivo", how=how) # type: ignore[arg-type]


@pytest.mark.filterwarnings("ignore:the default coalesce behavior")
def test_left_join(constructor: Constructor) -> None:
data_left = {
"antananarivo": [1.0, 2, 3],
Expand Down Expand Up @@ -272,7 +271,6 @@ def test_left_join(constructor: Constructor) -> None:
assert_equal_data(result_on_list, expected_on_list)


@pytest.mark.filterwarnings("ignore: the default coalesce behavior")
def test_left_join_multiple_column(constructor: Constructor) -> None:
data_left = {"antananarivo": [1, 2, 3], "bob": [4, 5, 6], "index": [0, 1, 2]}
data_right = {"antananarivo": [1, 2, 3], "c": [4, 5, 6], "index": [0, 1, 2]}
Expand All @@ -290,7 +288,6 @@ def test_left_join_multiple_column(constructor: Constructor) -> None:
assert_equal_data(result, expected)


@pytest.mark.filterwarnings("ignore: the default coalesce behavior")
def test_left_join_overlapping_column(constructor: Constructor) -> None:
data_left = {
"antananarivo": [1.0, 2, 3],
Expand Down
1 change: 0 additions & 1 deletion tests/hypothesis/join_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ def test_cross_join( # pragma: no cover
),
)
@pytest.mark.slow
@pytest.mark.filterwarnings("ignore:the default coalesce behavior")
def test_left_join( # pragma: no cover
a_left_data: list[int],
b_left_data: list[int],
Expand Down
3 changes: 0 additions & 3 deletions tests/spark_like_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,6 @@ def test_semi_join(
assert_equal_data(result, expected)


@pytest.mark.filterwarnings("ignore:the default coalesce behavior")
def test_left_join(pyspark_constructor: Constructor) -> None:
data_left = {
"antananarivo": [1.0, 2, 3],
Expand Down Expand Up @@ -874,7 +873,6 @@ def test_left_join(pyspark_constructor: Constructor) -> None:
assert_equal_data(result_on_list, expected_on_list)


@pytest.mark.filterwarnings("ignore: the default coalesce behavior")
def test_left_join_multiple_column(pyspark_constructor: Constructor) -> None:
data_left = {"antananarivo": [1, 2, 3], "bob": [4, 5, 6], "idx": [0, 1, 2]}
data_right = {"antananarivo": [1, 2, 3], "c": [4, 5, 6], "idx": [0, 1, 2]}
Expand All @@ -894,7 +892,6 @@ def test_left_join_multiple_column(pyspark_constructor: Constructor) -> None:
assert_equal_data(result, expected)


@pytest.mark.filterwarnings("ignore: the default coalesce behavior")
def test_left_join_overlapping_column(pyspark_constructor: Constructor) -> None:
data_left = {
"antananarivo": [1.0, 2, 3],
Expand Down
Loading