Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove class name from api completeness table, remove Expr.str.head / Expr.str.tail #1789

Open
MarcoGorelli opened this issue Jan 11, 2025 · 2 comments · May be fixed by #1801
Open

docs: remove class name from api completeness table, remove Expr.str.head / Expr.str.tail #1789

MarcoGorelli opened this issue Jan 11, 2025 · 2 comments · May be fixed by #1801
Labels
documentation Improvements or additions to documentation

Comments

@MarcoGorelli
Copy link
Member

The column with the class name is now redundant, as everything is split by class: https://narwhals-dev.github.io/narwhals/api-completeness/expr_str/

Also, str.head and str.tail we directly implement in terms of str.slice so we can remove them from the page (or rather, always show them as implemented with ✅ )
@MarcoGorelli MarcoGorelli added the documentation Improvements or additions to documentation label Jan 11, 2025
@MarcoGorelli
Copy link
Member Author

🤔 maybe we should also include polars on all pages, even if technically redundant, not sure how clear that is

@marvinl803 marvinl803 linked a pull request Jan 12, 2025 that will close this issue
Open
8 tasks
@FBruzzesi
Copy link
Member

Should we improve pages title as well? e.g. instead of ExprCatNamespace or Expr.cat we currently show Expr_cat. Just a thought :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Removed class, added polars to the table, str.head and str.tail are a… marvinl803/narwhals
2 participants
@MarcoGorelli @FBruzzesi