Skip to content

Commit

Permalink
rollback sort test
Browse files Browse the repository at this point in the history
  • Loading branch information
FBruzzesi committed Jan 10, 2025
1 parent 0e1f345 commit 790d829
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions tests/expr_and_series/sort_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import pytest

import narwhals.stable.v1 as nw
from tests.utils import Constructor
from tests.utils import ConstructorEager
from tests.utils import assert_equal_data

Expand All @@ -22,15 +21,9 @@
],
)
def test_sort_expr(
request: pytest.FixtureRequest,
constructor: Constructor,
descending: Any,
nulls_last: Any,
expected: Any,
constructor_eager: ConstructorEager, descending: Any, nulls_last: Any, expected: Any
) -> None:
if "pyspark" in str(constructor):
request.applymarker(pytest.mark.xfail)
df = nw.from_native(constructor(data))
df = nw.from_native(constructor_eager(data), eager_only=True)
result = df.select(
"a",
nw.col("b").sort(descending=descending, nulls_last=nulls_last),
Expand Down

0 comments on commit 790d829

Please sign in to comment.