Skip to content

feat: Disallow order-dependent expressions from being passed to nw.LazyFrame #9480

feat: Disallow order-dependent expressions from being passed to nw.LazyFrame

feat: Disallow order-dependent expressions from being passed to nw.LazyFrame #9480

Triggered via pull request January 14, 2025 11:27
Status Success
Total duration 16s
Artifacts

release-drafter.yml

on: pull_request
update_release_draft
7s
update_release_draft
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
update_release_draft
Resource not accessible by integration { name: 'HttpError', id: '12766671776', status: 403, response: { url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases', status: 403, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-encoding': 'gzip', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Tue, 14 Jan 2025 11:27:21 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'github.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', 'transfer-encoding': 'chunked', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'contents=write; contents=write,workflows=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': 'E800:2B10C5:224F8E:449452:67864A19', 'x-ratelimit-limit': '5000', 'x-ratelimit-remaining': '4959', 'x-ratelimit-reset': '1736857544', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '41', 'x-xss-protection': '0' }, data: { message: 'Resource not accessible by integration', documentation_url: 'https://docs.github.com/rest/releases/releases#create-a-release', status: '403' } }, request: { method: 'POST', url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.18.0 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"target_commitish":"refs/pull/1806/merge","name":"Narwhals unreleased","tag_name":"","body":"## Changes\\n\\n- docs: Removed class, added polars to the table, str.head and str.tail are a… (#1801)\\n\\n## ✨ Enhancements\\n\\n- feat: add `DataFrame` and `Series` `to_polars` (#1803)\\n- feat: add support for `SparkLikeNamespace.when` (#1805)\\n\\nThank you to all our contributors for making this release possible!\\n@EdAbati, @FBruzzesi, @MarcoGorelli and @marvinl803\\n","draft":true,"prerelease":false,"make_latest":"true"}', request: {} }, event: { id: '12766671776', name: 'pull_request', payload: { action: 'edited', changes: { body: { from: 'Another step closer to stable.v2\r\n' + '\r\n' + 'In a future version, we can add `order_by` to many of these, and then parametrise over all constructors without issues\r\n' + '\r\n' + 'This is work in progress\r\n' + '\r\n' + "Technically this would (breakingly) remove some methods for Dask, so the current behaviour could be preserved for `stable.v1`. I'm just not sure if it's worth it, given we don't seem to have any users for the Dask backend. We could just make the change, and if anyone complains we keep these available for Dask in v1\r\n" + '\r\n' + '<!--\r\n' + '# Thanks for contributing a pull request! \r\n' + '## Please make sure you see our contribution guidelines: https://github.com/narwhals-dev/narwhals/blob/main/CONTRIBUTING.md\r\n' + '-->\r\n' + '\r\n' + '## What type of PR is this? (check all applicable)\r\n' + '\r\n' + '- [ ] 💾 Refactor\r\n' + '- [ ] ✨ Feature\r\n' + '- [ ] 🐛 Bug Fix\r\n' + '- [ ] 🔧 Optimization\r\n' +
update_release_draft
HttpError: Resource not accessible by integration at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:8462:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:30793:18) { name: 'AggregateError', event: { id: '12766671776', name: 'pull_request', payload: { action: 'edited', changes: { body: { from: 'Another step closer to stable.v2\r\n' + '\r\n' + 'In a future version, we can add `order_by` to many of these, and then parametrise over all constructors without issues\r\n' + '\r\n' + 'This is work in progress\r\n' + '\r\n' + "Technically this would (breakingly) remove some methods for Dask, so the current behaviour could be preserved for `stable.v1`. I'm just not sure if it's worth it, given we don't seem to have any users for the Dask backend. We could just make the change, and if anyone complains we keep these available for Dask in v1\r\n" + '\r\n' + '<!--\r\n' + '# Thanks for contributing a pull request! \r\n' + '## Please make sure you see our contribution guidelines: https://github.com/narwhals-dev/narwhals/blob/main/CONTRIBUTING.md\r\n' + '-->\r\n' + '\r\n' + '## What type of PR is this? (check all applicable)\r\n' + '\r\n' + '- [ ] 💾 Refactor\r\n' + '- [ ] ✨ Feature\r\n' + '- [ ] 🐛 Bug Fix\r\n' + '- [ ] 🔧 Optimization\r\n' + '- [ ] 📝 Documentation\r\n' + '- [ ] ✅ Test\r\n' + '- [ ] 🐳 Other\r\n' + '\r\n' + '## Related issues\r\n' + '\r\n' + '- Related issue #\\<issue number\\>\r\n' + '- Closes #\\<issue number\\>\r\n' + '\r\n' + '## Checklist\r\n' + '\r\n' + '- [ ] Code follows style guide (ruff)\r\n' + '- [ ] Tests added\r\n' + '- [ ] Documented the changes\r\n' + '\r\n' + '## If you have comments or can explain your changes, please do so below\r\n' } }, number: 1806, organization: { avatar_url: 'https://avatars.githubusercontent.com/u/169070048?v=4', description: 'Narwhals developers', events_url: 'https://api.github.com/orgs/narwhals-dev/events', hooks_url: 'https://api.github.com/orgs/narwhals-dev/hooks', id: 169070048, issues_url: 'https://api.github.com/orgs/narwhals-dev/issues', login: 'narwhals-dev', members_url: 'https://api.github.com/orgs/narwhals-dev/members{/member}', node_id: 'O_kgDOChPN4A', public_members_url: 'https://api.github.com/orgs/narwhals-dev/public_members{/member}', repos_url: 'https://api.github.com/orgs/narwhals-dev/repos', url: 'https://api.github.com/orgs/narwhals-dev' }, pull_request: { _links: { comments: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1806/comments' }, commits: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/1806/commits' }, html: { href: 'https://github.com/narwhals-dev/narwhals/pull/1806' }, issue: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1806' }, review_comment: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/comments{/number}' }, review_comments: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/1806/comments' }, self: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/1806' }, statuses: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/st
update_release_draft
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636