Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing normalization factor in likelihood #406

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

vhaasteren
Copy link
Member

This adds a normalization factor in the likelihood so that the likelihood is normalized.

This fixes #405

@vhaasteren vhaasteren self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.74%. Comparing base (6fa7e04) to head (d983de7).
Report is 8 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #406      +/-   ##
==========================================
+ Coverage   71.64%   71.74%   +0.09%     
==========================================
  Files          13       13              
  Lines        3231     3228       -3     
==========================================
+ Hits         2315     2316       +1     
+ Misses        916      912       -4     
Files with missing lines Coverage Δ
enterprise/signals/signal_base.py 90.23% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cf788...d983de7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant