test(render): add integration tests to check rendering output #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- all folders in example folder are considered a myks rendered repository. - every change, which is change the rendered output must commit the changes as part of the PR, otherwise the test will fail
Workaround for #91. The integration tests needs a clean git state.
Output was not rerendered after renaming.
Zebradil
approved these changes
Oct 30, 2023
cmd/all.go
Outdated
| log.Fatal().Err(err).Msg("Root directory is not suitable for myks") | ||
| } | ||
|
|
||
| log.Info().Msg("Init################") |
There was a problem hiding this comment.
Is it leftovers after debugging?
Zebradil
approved these changes
Oct 30, 2023
cmd/all.go
Outdated
| log.Fatal().Err(err).Msg("Root directory is not suitable for myks") | ||
| } | ||
|
|
||
| log.Info().Msg("Init################") |
|
Great work, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All folders in example folder are considered a myks rendered repository.
The test in internal/integration/ will rerender all envs and applications. Nothing should be changed afterwards.
This enforces that every PR will contain all the introduced changes in the rendered output (breaking change) as part of the PR.
This PR is huge due to the examples folders. The examples should be save to be ignored for now.