Releases/v4.2.0 #255
Merged
Releases/v4.2.0 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dispatch a viewend automatically and tear down player monitoring when the application shuts down
daytime-em
requested changes
Nov 22, 2024
|
PR for the issue: #256 edit:also fixes the build |
daytime-em
approved these changes
Nov 22, 2024
|
(Approved but we still need to update the XCFramework) |
|
A draft release has been created for this version. Find it here! https://github.com/muxinc/mux-stats-sdk-avplayer/releases/tag/untagged-87c7a56698cd9ea84bf7 |
andrewjl-mux
added a commit
that referenced
this pull request
Nov 23, 2024
* fix: send `ended` when an AVPlayerItem finishes playing to completion (#254) * fix: remove NSLog and comment lines --------- Co-authored-by: Emily Dixon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
endedwhen an AVPlayerItem finishes playing to completion (fix: sendendedwhen an AVPlayeritem ends #254)Co-authored-by: AJ Lauer Barinov [email protected]
Co-authored-by: Emily Dixon [email protected]