build: add xcconfig, to simplify version updates #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrewjl-mux
commented
Oct 16, 2024
•
andrewjl-mux
commented
- Add xcconfig for each target, to simplify version updates
- Remove iOS 11 deployment target flags that aren't applicable (and would result in build failures on Xcode 15+ if they were)
- Add Xcode path log to static build script for consistency
- Skip SPM and Cocoapods tests on non-release branches
dispatch a viewend automatically and tear down player monitoring when the application shuts down
daytime-em
approved these changes
Oct 16, 2024
andrewjl-mux
changed the base branch from
ajlb/fix/tear-down-view-on-hard-application-termination
to
releases/v4.1.1
Merged
andrewjl-mux
added a commit
that referenced
this pull request
Oct 18, 2024
* fix: tear down view on hard application termination dispatch a viewend automatically and tear down player monitoring when the application shuts down * build: add xcconfig, to simplify version updates * build: use per target xcconfig to match core * ci: consistent logs * ci: make these scripts consistent * fix indentation * build: add comments on config names * ci: skip lengthy app tests when not on release branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.