give up null partitions

Signed-off-by: Murphy <[email protected]>
murphyatwork · Dec 3, 2024 · c891f89 · c891f89
1 parent 6f50381
commit c891f89
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/...ava/com/starrocks/sql/optimizer/rule/transformation/PartitionColumnMinMaxRewriteRule.java b/...ava/com/starrocks/sql/optimizer/rule/transformation/PartitionColumnMinMaxRewriteRule.java
@@ -226,10 +226,15 @@ private OptExpression optimizeWithPartitionPrune(OptExpression optExpression,
         if (hasMinMax.first) {
             List<Long> sorted = partitionInfo.getSortedPartitions(true);
             sorted.retainAll(nonEmptyPartitionIds);
-            sorted.removeAll(nullPartitions);
             if (CollectionUtils.isEmpty(sorted)) {
                 return null;
             }
+            // TODO: in theory if we can confirm one partition contains only NULL values, we can rule out these
+            //  partitions from sorted. But currently a range-partition can contains both NULL value and regular
+            //  values
+            if (nullPartitions.contains(sorted.get(0))) {
+                return null;
+            }
             pruned.add(sorted.get(0));
         }
 
@@ -240,6 +245,9 @@ private OptExpression optimizeWithPartitionPrune(OptExpression optExpression,
             if (CollectionUtils.isEmpty(sorted)) {
                 return null;
             }
+            if (nullPartitions.contains(sorted.get(0))) {
+                return null;
+            }
             pruned.add(sorted.get(0));
         }