Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move multibase prefixes out of this table #90

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Nov 15, 2018

Resolution from a discussion with Juan (offline) and the discussion on the following issues:

fixes #89
fixes #76

Resolution from a discussion with Juan and the discussion on the following
issues:

fixes #89
fixes #76
@ghost ghost assigned Stebalien Nov 15, 2018
@ghost ghost added the in progress label Nov 15, 2018
@Stebalien Stebalien requested a review from daviddias November 15, 2018 19:25
@Stebalien
Copy link
Member Author

Basically, while technically correct, the symbol distinction doesn't actually make this any less confusing.

@vmx
Copy link
Member

vmx commented Dec 18, 2018

I really like this change, I don't see anyone being against it, hence merging it.

@vmx vmx merged commit 1ec0e97 into master Dec 18, 2018
@ghost ghost removed the in progress label Dec 18, 2018
@vmx vmx deleted the feat/move-out-multibase branch December 18, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many Code duplicates Text, raw varint, bytecode distinction
2 participants