Add initial list of actual Multihash.Type implementations to README #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oups, hand on, don't merge this just yet, this mapping re. Google Guava's Hashing is actually wrong; I'll update the PR in a minute:
|
Nope, that was totally correct; I'm just stupid, and it just took at least me a while to dig that (which is why IMHO it's useful to document):
I've now added a few more, and this is now ready for review and merge as-is, from my side. |
|
@ianopolous sorry I don't know if you read along all comments, or want an explicit ping to re-review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ianopolous how about this, as fixes #41 ?