Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Berlin #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Berlin #56

wants to merge 4 commits into from

Conversation

azrdev
Copy link
Collaborator

@azrdev azrdev commented Oct 14, 2017

maybe @kaifabian wants to tell how/where this shall be hosted in the future

Studierendenwerk Berlin reworked their website, so the old parser is
defunct, see kaifabian/om-parser-berlin#1

This new parser parses all meals with all prices, TODO are:
- annotations/legend
- test all the various canteens
@kaifabian
Copy link

@azrdev This looks good. Thanks for your efforts!
I will discuss hosting of the new parser with @mswart and get back to you. :)

@escrl
Copy link

escrl commented Oct 17, 2017

Hi, I also had a look into it, see #57. I don't care which one you choose, but this one has tow little flaws:
(1) Imho if only one price is provided on the website, this should be assumed to be the price for all groups.
(2) There are some cafeterias like fu_rechtswissenschaft, that serve salad dressings even when they are closed. I try to detect this by marking days, where only items without a price tag are served as closed.

@lenucksi
Copy link

Any news on the state of this one?

@kaifabian
Copy link

IMHO the only open question is whether to use @escrl's or @azrdev's parser. Once that's settled we just need the parser endpoint(s) and user ID of the parser owner. Then @mswart or @jgraichen could replace those informations in the database (so that canteen IDs do not get changed).

@escrl
Copy link

escrl commented Jan 12, 2018

I already send you details on my parses to [email protected]. As I have no suitable hosting site atm, I run my parser as a cron job on local machines and push result to github at https://github.com/escrl/openmensa-feed-berlin. Only problem that remains with my parser is that automatic updates within openmensa of the feeds don't work, even though I added schedule tags to metadata (e.g. https://raw.githubusercontent.com/escrl/openmensa-feed-berlin/master/mensa_hu_nord/metadata.xml).

@mswart
Copy link
Owner

mswart commented Jan 12, 2018

I try to find time to deal with Berlin this week end.

@ghost
Copy link

ghost commented Feb 10, 2018

Status? :)

@mswart
Copy link
Owner

mswart commented Feb 13, 2018

@Patte1808 Sorry for the delay. Over the last weeks both @escrl and myself didn't get any new errror reports. We didn't examined the situation in details and simply assumed everything is working again.
A couple of bugs has been fixed yesterday. All canteens should now have valid meal information.

Please report back if you encounter further issues.

@kaifabian
Copy link

kaifabian commented Oct 15, 2018

Any update on this? I am closing down kaifabian/om-parser-berlin now. I assume that escrl/openmensa-parser-berlin (and escrl/openmensa-feed-berlin) is the new home of Berlins canteen feeds? Then this PR should be closed in favor of said repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants