remove provisioner as receiver of uploadfiles util func

CHANGELOG.md

@@ -1,3 +1,5 @@
+### 1.5.0 (Next)
+
 ### 1.4.2
 - Significantly improve Packer SSH and WinRM communicators settings' interfacing with provisioner plugin.
 

provisioner/util.go

@@ -11,7 +11,7 @@ import (
 )
 
 // helper function to transfer files from local device to temporary packer instance
-func (provisioner *Provisioner) uploadFiles(comm packer.Communicator, files []string, destDir string) error {
+func uploadFiles(comm packer.Communicator, files []string, destDir string) error {
 	var err error
 
 	// iterate through files to transfer

provisioner/util_test.go

@@ -9,16 +9,15 @@ import (
 )
 
 func TestProvisionerUploadFiles(test *testing.T) {
-	var provisioner Provisioner
 	comm := new(packer.MockCommunicator)
 
-	err := provisioner.uploadFiles(comm, []string{}, "/tmp/")
+	err := uploadFiles(comm, []string{}, "/tmp/")
 	if err != nil {
 		test.Errorf("uploadFiles with empty files slice input returned error")
 		test.Error(err)
 	}
 
-	err = provisioner.uploadFiles(comm, []string{"foobar"}, "/tmp/")
+	err = uploadFiles(comm, []string{"foobar"}, "/tmp/")
 	if !errors.Is(err, os.ErrNotExist) {
 		test.Errorf("expected nonexistent file to return ErrNotExist error, but instead %s was returned", err)
 	}