Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nimbus): Make name field in new UI required #12020

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

RJAK11
Copy link
Contributor

@RJAK11 RJAK11 commented Jan 10, 2025

Because

  • Submitting a form with an empty name field in the new Nimbus UI causes a 500 error.

This commit

  • Adds validation to ensure the name field is required and prevents submission with an empty value

Fixes #12016

Because

- Submitting a form with an empty name field in the new Nimbus UI causes a 500 error.

This commit

- Adds validation to ensure the name field is required and prevents submission with an empty value

Fixes #12016
@RJAK11 RJAK11 marked this pull request as ready for review January 10, 2025 15:53
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Couple ideas for the test 🙏

Because

- Submitting a form with an empty name field in the new Nimbus UI causes a 500 error.

This commit

- Adds validation to ensure the name field is required and prevents submission with an empty value

Fixes #12016
@RJAK11 RJAK11 requested a review from jaredlockhart January 10, 2025 16:39
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay fantastic, tested locally, works perfectly, thnx @RJAK11 🎉

@RJAK11 RJAK11 added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit ec57e0c Jan 13, 2025
16 checks passed
@RJAK11 RJAK11 deleted the require-name-12016 branch January 13, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty name in new nimbus ui raises 500
2 participants