Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cirrus): V2 api #12008

Merged
merged 6 commits into from
Jan 15, 2025
Merged

feat(cirrus): V2 api #12008

merged 6 commits into from
Jan 15, 2025

Conversation

yashikakhurana
Copy link
Contributor

Because

  • We want to return features under the key Features
  • We don't send back enrollment responses to the calling application and sometimes its hard to find if they are in the experiment or not

This commit

  • Returns feature and enrollments as part of the new v2 api

Fixes #12000 #12001

@yashikakhurana yashikakhurana mentioned this pull request Jan 10, 2025
Merged
jaredlockhart
jaredlockhart previously requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep logic all looks good, we should try to split the tests up to more clearly separate the cases. Thanks @yashikakhurana !

cirrus/server/tests/test_main.py Outdated Show resolved Hide resolved
cirrus/server/tests/test_main.py Outdated Show resolved Hide resolved
jaredlockhart
jaredlockhart previously requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, everything looks great, thank you for the test changes, they're very clear and read nicely. Just one last thing to make sure we keep v1 intact and then I think this is good to go 🙏

demo-app/server/index.js Outdated Show resolved Hide resolved
jaredlockhart
jaredlockhart approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooooo, this is fantastic thanks so much @yashikakhurana 🥳 🎉 🎉 🎉 🎉

@yashikakhurana yashikakhurana added this pull request to the merge queue Jan 15, 2025
Merged via the queue into mozilla:main with commit 53dcf84 Jan 15, 2025
15 checks passed
@yashikakhurana yashikakhurana deleted the 12000/cirrus_v2_api_enrollment_data branch January 15, 2025 18:52
yashikakhurana added a commit that referenced this pull request Jan 15, 2025
@yashikakhurana
Revert "feat(cirrus): V2 api (#12008)"
7adf4f4 
This reverts commit 53dcf84.
@yashikakhurana yashikakhurana mentioned this pull request Jan 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 15, 2025
@yashikakhurana
Revert "feat(cirrus): V2 api" (#12056)
ee8f9da 
Because
- Monitor is getting error on prod

This Commit 
- Reverts #12008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

@jeddai jeddai Awaiting requested review from jeddai jeddai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2 api-Cirrus returns the enrollment data in the response
2 participants
@yashikakhurana @jaredlockhart