Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): Pin poetry version to 1.8.4 #11999

Merged
merged 1 commit into from
Jan 7, 2025
Merged

chore(project): Pin poetry version to 1.8.4 #11999

merged 1 commit into from
Jan 7, 2025

Conversation

b4handjr
Copy link
Contributor

@b4handjr b4handjr commented Jan 7, 2025

Because

  • Poetry introduced some breaking changes with their v2 release

This commit

  • Pins all poetry installs to 1.8.4 for now.

Fixes #11998

@b4handjr b4handjr requested a review from mikewilli January 7, 2025 18:57
@b4handjr b4handjr changed the title chore(project): Pin poetry versions to 1.8.5 chore(project): Pin poetry version to 1.8.5 Jan 7, 2025
@b4handjr b4handjr enabled auto-merge January 7, 2025 19:16
Copy link
Contributor

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

I'd suggest 1.8.4 for this change because we use that in all of the other Dockerfiles (except Cirrus which is on 1.6.0?), or updating those to match, but don't think that's a big deal.

We may want to consider using POETRY_VERSION env var as well in the future.

Want to file a ticket for whichever of the above you don't include here?

@b4handjr b4handjr added this pull request to the merge queue Jan 7, 2025
@b4handjr b4handjr removed this pull request from the merge queue due to a manual request Jan 7, 2025
@b4handjr
Copy link
Contributor Author

b4handjr commented Jan 7, 2025

LGTM thanks!

I'd suggest 1.8.4 for this change because we use that in all of the other Dockerfiles (except Cirrus which is on 1.6.0?), or updating those to match, but don't think that's a big deal.

We may want to consider using POETRY_VERSION env var as well in the future.

Want to file a ticket for whichever of the above you don't include here?

Good catch, ill do 1.8.4 then. Not a big difference between the two.

@b4handjr b4handjr enabled auto-merge January 7, 2025 19:23
@b4handjr b4handjr changed the title chore(project): Pin poetry version to 1.8.5 chore(project): Pin poetry version to 1.8.4 Jan 7, 2025
@b4handjr b4handjr added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit de23ccd Jan 7, 2025
16 checks passed
@b4handjr b4handjr deleted the fix-11998 branch January 7, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin poetry install command to 1.8.4 for now
2 participants