feat(nimbus): Add tooltips to new experiment timeline #11991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RJAK11
force-pushed
the
tooltips-11748
branch
2 times, most recently
from
e49b953 to
8555514
Compare
Because - The new UI is missing the tooltips on the timeline This commit - Adds tooltips to the new experiment timeline explaining what each count of days on the timeline means Fixes #11748
RJAK11
requested review from
jaredlockhart,
yashikakhurana and
brennie
as code owners
yashikakhurana
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Overall it looks good, coming up in good shape, just some minor changes needed, thanks @RJAK11
experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/experiment_base.html
Outdated
Show resolved
Hide resolved
Because - The new UI is missing the tooltips on the timeline This commit - Adds tooltips to the new experiment timeline explaining what each count of days on the timeline means Fixes #11748
Because - The new UI is missing the tooltips on the timeline This commit - Adds tooltips to the new experiment timeline explaining what each count of days on the timeline means Fixes #11748
yashikakhurana
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
I really like the new UI tool tip you have used this time, thanks @RJAK11 🎉
Because - The new UI is missing the tooltips on the timeline This commit - Adds tooltips to the new experiment timeline explaining what each count of days on the timeline means Fixes #11748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #11748
Cursor does not show up in the screenshots.
