Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add results link to experiments table #11990

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add results link to experiments table #11990

wants to merge 2 commits into from

Conversation

mikewilli
Copy link
Contributor

Because

  • it is impossible to tell if an experiment has results without clicking into it
  • it can be useful to see a list of experiments with/without results
  • it can be useful to navigate directly to the experiment's results

This commit

  • adds a results link to the experiments table if results exist

Fixes #10946
image

yashikakhurana
yashikakhurana reviewed Jan 8, 2025
View reviewed changes
experimenter/experimenter/nimbus_ui_new/templates/nimbus_experiments/table.html
Comment on lines +123 to +125
{% if experiment.show_results_url %}
<a href="{% url "nimbus-results" slug=experiment.slug %}">Results</a>
{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍 , just in case if results are not available do you want to say not available or may be some other placeholder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember right, we previously left the links column blank if there were no links to display, but I'm happy to put "N/A" or something else here if you think that would be better. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just change the text from Result to View Results and if they are not available link won't be active, but I think what you have clearly tells if the results are available or not, or just simply put N/A if its not available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashikakhurana yashikakhurana yashikakhurana left review comments

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart will be requested when the pull request is marked ready for review jaredlockhart is a code owner

@brennie brennie Awaiting requested review from brennie brennie will be requested when the pull request is marked ready for review brennie is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add results link to experiment row when results are available
2 participants
@mikewilli @yashikakhurana