Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-duplicat-info - Avoid to nag forever because a bug hasn't a cf_crash_signature field #1237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

Copy-duplicat-info - Avoid to nag forever because a bug hasn't a cf_crash_signature field #1237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion auto_nag/scripts/copy_duplicate_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def handle_bug(self, bug, data):
data[bugid] = {
"id": bugid,
"summary": self.get_summary(bug),
"signature": bug.get("cf_crash_signature", ""),
"signature": bug.get("cf_crash_signature", None),
"dupe": str(bug["dupe_of"]),
"product": bug["product"],
"component": bug["component"],
Expand Down Expand Up @@ -117,6 +117,10 @@ def compare(self, bugs, dups):

dup = dups[dupid]
bs = utils.get_signatures(info["signature"])
if dup["signature"] is None:
# some bugs don't have a cf_crash_signature field... it's weird
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you ask dkl about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes in #bmo on slack.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the problem? Is it a bug or a feature? :P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://bugzilla.mozilla.org/show_bug.cgi?id=1742458

# but it's life...
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log a warning?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the bug is going to be fixed, let's log a warning so we don't silently ignore the problem if it reappears

ds = utils.get_signatures(dup["signature"])
if not bs.issubset(ds):
signatures[dupid] = bs - ds
Expand Down