This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 856888 - Support links was added in calendar's notes #33545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,32 @@ | |||
| /*global ActivityPicker */ | |||
There was a problem hiding this comment.
This should use amd like our other modules. ie
define(function(require, exports, module) {
'use strict';
module.exports = function lah_onClick(event) {
// ...
};
});
**What was made: ** * Move modules that provides convertion telephone numbers, emails and links to links in messages to shared component from sms. * Add this functionality in calendar's notes.
ruvsmirnov
force-pushed
the
bug-856888-calendar-notes-links-clickable-provided
branch
from
4701c2c to
3609ecc
Compare
| /* global ActivityPicker */ | ||
|
|
||
| define(function(require, exports, module) { | ||
| 'use strict'; |
There was a problem hiding this comment.
nit: Move code inside module 2 spaces left
|
I think I'd prefer that you recreate a simpler ActivityPicker inside the Calendar app. As you see, the full ActivityPicker you moved is used for other things than only the links handler (see in apps/sms/views/conversation/js/conversation.js for example). You could even recreate it directly in link_action_handler.js. Nowadays we can also use MozActivity like a promise, so we don't need to use onsuccess/onerror like we do in activity_picker. We can merely return |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was made: