-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update lecture&course of course7 #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"enables" is more appropriate than "allows" here.
yes, enable means "to make something possible" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is far better than the first version. However modifications still need to be made as the existing explanations are too short (or missing) and the organization is a bit wierd. Since this is a document, you are free to have deeper level then just header level 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change all i = i +1
into i += 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update some details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be easier if you just translate the script and insert the examples in the right place as #3 (for the following chapters).
course7/course_en.md
Outdated
```moonbit | ||
// Loop form | ||
let mut i = 0 | ||
while i < 2, i = i + 1 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mdlint run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already run. no warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DawnMagnet Are you sure that you used the correct markdown linter (@moonbit/markdown-linter
, not mdlint
) to check the document?
Could you please do a rebase? |
already rebase |
I triggered the CI job and now you can see the changes needed |
I think many of the |
Using |
I think the content is pretty good, except that MoonBit is sometimes written as “Moonbit”. |
Also, the author should be "MoonBit Open Course Team". |
@peter-jerry-ye