Deprecated items do not need a description #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=========================================
Coverage 97.87% 97.88%
Complexity 844 844
=========================================
Files 37 37
Lines 2499 2500 +1
=========================================
+ Hits 2446 2447 +1
Misses 53 53 ☔ View full report in Codecov by Sentry. |
stronk7
reviewed
Mar 28, 2024
Whilst working on recent changes I've been wishing I'd done this in the first place. Often you will want the pointer, and you'll want to pass that pointer to methods like getMatchingTags more than once.
andrewnicols
force-pushed
the
missingDocblockDeprecated
branch
from
f94ac4b to
b425006
Compare
stronk7
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised by @ziegenberg
Note: I've included an extra commit her eto slightly refactor the Docblocks util to use the docblockPtr rather than find it from an unrelated pointer. This is much more efficient and I should have done this originally.