Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added necessary step to composer installation #830

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

t-schroeder
Copy link
Contributor

until there is a stable version of phpcompatibility that we can require

until there is a stable version of phpcompatibility that we can require
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a63ce48
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/656f32f59ea40c0008c81e9b
😎 Deploy Preview https://deploy-preview-830--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@t-schroeder
Copy link
Contributor Author

See moodlehq/moodle-cs#79

Copy link
Contributor

github-actions bot commented Dec 5, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 62 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 68 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 65 🟠 87 🟢 92 🟢 100 🟢 100 Report

@stronk7
Copy link
Member

stronk7 commented Dec 5, 2023

Thanks @t-schroeder ,

makes sense and matches what is already documented @ moodle-cs, so LGTM.

@stronk7 stronk7 added this pull request to the merge queue Dec 5, 2023
Merged via the queue into moodle:main with commit be110f4 Dec 5, 2023
7 checks passed
@stronk7
Copy link
Member

stronk7 commented Dec 5, 2023

OT, it's really curious that I've tried here installing it, both globally and in a temp dir... I've not got the "minimum-stability" set (neither globally, neither in the composer.json file itself).

There is some detail that I must be missing... anyway, let's hope a new release happens soon.

Ciao :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants