Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDL-83725 activity icon colors update note #1224

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ferranrecio
Copy link
Collaborator

Adding an update note about the new activity purpose colors SCSS variables.

@ferranrecio ferranrecio added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 8, 2025
Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e11fc13
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/677e57375392f800082e4600
😎 Deploy Preview https://deploy-preview-1224--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 64 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/5.0/apis/commonfiles 🔴 48 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 55 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 50 🟢 95 🟢 100 🟢 100 🟢 100 Report

Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the proper issueNumber = "MDL-83725" instead of a generic issueNumber="MDL-XXXXX", please?

Adding an update note about the new activity purpose colors
SCSS variables.
@ferranrecio
Copy link
Collaborator Author

Hi @aanabit ,

Ups, the first day after a long break. MDL code fixed ;-)

Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine to me now, so I'm accepting this PR.

@sarjona sarjona removed the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 8, 2025
@sarjona sarjona added this pull request to the merge queue Jan 10, 2025
Merged via the queue into moodle:main with commit 9dae324 Jan 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants