DOP-5317: Populate-metadata extension supports content-repo-sourced deployments #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redoc-extension canceled.
|
✅ Deploy Preview for snooty-cache-extension canceled.
|
✅ Deploy Preview for populate-data-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for git-changed-file-extension canceled.
|
✅ Deploy Preview for redirects-and-publish-extension canceled.
|
✅ Deploy Preview for search-manifest-extension canceled.
|
✅ Deploy Preview for persistence-module-ext canceled.
|
✅ Deploy Preview for slack-deploy-extension canceled.
|
anabellabuckvar
changed the title
seungpark
reviewed
Jan 24, 2025
| @@ -84,26 +87,18 @@ const cloneContentRepo = async ({ | |||
| branchName: string; | |||
| orgName: string; | |||
| }) => { | |||
| if (fs.existsSync(repoName)) { | |||
| if (fs.existsSync(`${repoName}`)) { | |||
There was a problem hiding this comment.
minor. is this necessary to interpolate here
| await run.command(`rm -r ${repoName}`); | ||
| } | ||
|
|
||
| await run.command( | ||
| `git clone -b ${branchName} --recurse-submodules https://${process.env.GITHUB_BOT_USERNAME}:${process.env.GITHUB_BOT_PWD}@github.com/${orgName}/${repoName}.git -s`, | ||
| `git clone -b ${branchName} https://${process.env.GITHUB_BOT_USERNAME}:${process.env.GITHUB_BOT_PWD}@github.com/${orgName}/${repoName}.git -s`, |
There was a problem hiding this comment.
qq - why did we get rid of this option --recurse-submodules
| ); | ||
|
|
||
| // Remove git config as it stores the connection string in plain text | ||
| if (fs.existsSync(`${repoName}/.git/config`)) { | ||
| await run.command(`rm -r ${repoName}/.git/config`); | ||
| } | ||
|
|
There was a problem hiding this comment.
is this not necessary anymore?
| await run.command(`rm -r ${repoName}`); | ||
| } | ||
|
|
||
| await run.command( | ||
| `git clone -b ${branchName} --recurse-submodules https://${process.env.GITHUB_BOT_USERNAME}:${process.env.GITHUB_BOT_PWD}@github.com/${orgName}/${repoName}.git -s`, | ||
| `git clone -b ${branchName} https://${process.env.GITHUB_BOT_USERNAME}:${process.env.GITHUB_BOT_PWD}@github.com/${orgName}/${repoName}.git -s`, | ||
| ); | ||
|
|
||
| // Remove git config as it stores the connection string in plain text |
There was a problem hiding this comment.
also wondering if we can replace the contents of said doc to ./ folder of runner so that the structure is the same as a docs content repo.
this will be saving as:
| snooty
| -- cloud-docs
| ---- source
| ------ index.html
whereas the builds on docs sites have the structure:
| cloud-docs
| -- source
| ---- index.html
| -- snooty
we can make this a follow up ticket to keep the file structure the same
| : (process.env.BRANCH_NAME ?? (configEnvironment.BRANCH as string)); | ||
| const repoName = | ||
| process.env.REPO_NAME ?? | ||
| (process.env.REPOSITORY_URL?.split('/')?.pop() as string); |
There was a problem hiding this comment.
minor. should we be reading from configEnvironment here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-5317 Populate-metadata extension supports content-repo-sourced deployments
Notes
Changes how populate-metadata netlify extension populates build environment env variables,. to support the transition to content-repo sourced deploys in dotcomstg, dotcomprd
Deployed version of populate-metadata extension
Docs build