Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-4840 Add evergreen tests for free-threaded Python 3.13t #2048

Merged
merged 26 commits into from
Jan 7, 2025

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 6, 2025

@blink1073 blink1073 requested a review from ShaneHarvey January 6, 2025 14:38
`Free-threaded CPython <https://docs.python.org/3.13/whatsnew/3.13.html#whatsnew313-free-threaded-cpython>`_.
We do not yet support free-threaded Python on Windows (`PYTHON-5027`_) or with Encryption (`PYTHON-5024`_).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encryption -> "In-Use Encryption".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

working_dir: "src"
binary: bash
include_expansions_in_env: ["PYTHON_BINARY"]
args: [ .evergreen/scripts/run-direct-tests.sh ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a new entry point to test free threading?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hatch doesn't work with it, because it depends on cryptography. It made more sense to me to add this specific entry point then try to hack back in a "SKIP_HATCH" flag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks SGTM

@blink1073 blink1073 requested a review from ShaneHarvey January 6, 2025 22:33
ShaneHarvey
ShaneHarvey previously approved these changes Jan 6, 2025
@blink1073
Copy link
Member Author

I had to resolve a merge conflict in the changelog.

@blink1073 blink1073 requested a review from ShaneHarvey January 7, 2025 02:03
@blink1073 blink1073 merged commit c40283e into mongodb:master Jan 7, 2025
45 of 48 checks passed
@blink1073 blink1073 deleted the PYTHON-4840 branch January 7, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants