Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYTHON-4721 - Create individualized scripts for all shell.exec commands #1997

Merged
merged 52 commits into from
Nov 20, 2024
Merged

PYTHON-4721 - Create individualized scripts for all shell.exec commands #1997

merged 52 commits into from
Nov 20, 2024

Conversation

NoahStapp
Copy link
Contributor

@NoahStapp NoahStapp commented Nov 7, 2024 •
edited
Loading

OCSP and AWS Auth tests are still failing.

@NoahStapp NoahStapp requested review from blink1073 and removed request for blink1073 November 7, 2024 18:57
@NoahStapp NoahStapp marked this pull request as draft November 7, 2024 18:58
@blink1073
Copy link
Member

We need to handle SKIP_CSOT_TESTS as well.

@blink1073 blink1073 self-requested a review November 7, 2024 21:23
blink1073
blink1073 reviewed Nov 7, 2024
View reviewed changes
.evergreen/config.yml Outdated Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved
.evergreen/config.yml Outdated

"run-ocsp-server":
- command: subprocess.exec
params:
background: true
binary: bash
include_expansions_in_env: [SERVER_TYPE, OCSP_ALGORITHM]
include_expansions_in_env: ["SERVER_TYPE", "OCSP_ALGORITHM"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need quotes for these in general unless they have an expansion.

.evergreen/scripts/prepare-resources.sh
else
git clone https://github.com/mongodb-labs/drivers-evergreen-tools.git $DRIVERS_TOOLS
fi
echo "{ \"releases\": { \"default\": \"$MONGODB_BINARIES\" }}" >$MONGO_ORCHESTRATION_HOME/orchestration.config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make the call to https://github.com/mongodb-labs/drivers-evergreen-tools/blob/master/.evergreen/setup.sh in this file.

.evergreen/scripts/run-ocsp-test.sh Show resolved Hide resolved
.evergreen/scripts/run-tests.sh Outdated

. .evergreen/scripts/env.sh
if [ -n "${test_encryption}" ]; then
./.evergreen/hatch.sh encryption:setup &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to break this out the way we handle it in the go driver, as a separate background command: https://github.com/mongodb/mongo-go-driver/blob/cf0348c9a63f6e4086e2c62aa62e70a9d3b3a986/.evergreen/config.yml#L508

.evergreen/scripts/teardown-aws.sh Show resolved Hide resolved
blink1073
blink1073 reviewed Nov 7, 2024
View reviewed changes
.evergreen/config.yml Outdated Show resolved Hide resolved
@blink1073 blink1073 mentioned this pull request Nov 8, 2024
Closed
34 tasks
@blink1073
Copy link
Member

FYI I added Encryption RHEL8 Python3.10 to the default tasks that run.

@NoahStapp NoahStapp requested a review from blink1073 November 14, 2024 17:30
@blink1073
Copy link
Member

blink1073 commented Nov 14, 2024 •
edited
Loading

I scheduled a cross-section of build variants, there were a few failures

@blink1073
Copy link
Member

It looks like we can't use PYTHON_BINARY yet for run-orchestration:

[2024/11/19 11:07:18.874]   File "/Library/Frameworks/Python.Framework/Versions/3.13/lib/python3.13/urllib/request.py", line 1322, in do_open
[2024/11/19 11:07:18.874]     raise URLError(err)
[2024/11/19 11:07:18.874] urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1020)>

Something might be off about the 3.13 toolchain because of the free-threading build.

@NoahStapp
Copy link
Contributor Author

It looks like we can't use PYTHON_BINARY yet for run-orchestration:

[2024/11/19 11:07:18.874]   File "/Library/Frameworks/Python.Framework/Versions/3.13/lib/python3.13/urllib/request.py", line 1322, in do_open
[2024/11/19 11:07:18.874]     raise URLError(err)
[2024/11/19 11:07:18.874] urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1020)>

Something might be off about the 3.13 toolchain because of the free-threading build.

Correct, I went ahead and removed PYTHON_BINARY from anywhere it wasn't before.

@blink1073
Copy link
Member

Hold off on further pushes for a bit please, I scheduled a cross-section of tasks. So far we have:

no-server and other-hosts tests are failing with: .evergreen/scripts/run-tests.sh: line 44: PYTHON_BINARY: unbound variable.

@blink1073
Copy link
Member

looks like serverless is missing auth: OperationFailure('(Unauthorized) not authorized on admin to execute command

@blink1073
Copy link
Member

AWS failure: .evergreen/scripts/run-with-env.sh: line 21: AWS_ROLE_SESSION_NAME="test": No such file or directory

@blink1073
Copy link
Member

Encryption PyOpenSSL RHEL8 PyPy3.10 - maybe missing SSL config: AssertionError: "IP address mismatch|wronghost|IPAddressMismatch|Certificate" does not match "SSL handshake failed

@blink1073
Copy link
Member

Okay that looks like all of the failures.

@NoahStapp
Copy link
Contributor Author

looks like serverless is missing auth: OperationFailure('(Unauthorized) not authorized on admin to execute command

It's running with auth, didn't we see this error previously as well?

@blink1073
Copy link
Member

Ah, yep, PYTHON-4963.

blink1073
blink1073 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@NoahStapp NoahStapp merged commit 1c7a7fe into mongodb:master Nov 20, 2024
77 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoahStapp @blink1073 @Jibola