PYTHON-4784 - Add tests to confirm async parallelism #1886
Conversation
|
|
||
| class TestAsyncConcurrency(AsyncIntegrationTest): | ||
| async def _task(self, client): | ||
| await client.db.test.find_one({"$where": delay(1)}) |
There was a problem hiding this comment.
This 1 second delay makes the test take 6 seconds which is too long. Can we lower the sleep to something more like at most 50ms?
There was a problem hiding this comment.
Very short sleeps like 50ms don't have a very large time delta due to our 500ms poll timeout. With a 50ms delay, the concurrent version is consistently only 0-10% faster and highly variable.
There was a problem hiding this comment.
My testing with #1870 confirms that this is due to our blocking of the asyncio loop. If we wait to merge that PR before this one, I can lower the timeout to around 10ms.
There was a problem hiding this comment.
Does this test pass consistently on macos and windows?
Looks like it doesn't pass consistently on linux:
https://spruce.mongodb.com/task/mongo_python_driver_tests_python_version_rhel8_test_ssl__platform~rhel8_auth_ssl~auth_ssl_python_version~3.10_coverage~coverage_test_3.6_replica_set_patch_b111cbf5d5dab906a94d2c4b2a209cfde2971a94_66feef335bc7120007d6bca4_24_10_03_19_23_36?execution=0&sortBy=STATUS&sortDir=ASC
Perhaps raise the timeout to 100m or 200ms and limit it to only linux?
It was passing consistently for me, but could be the difference between local and remote latency. I'll up the timeout and lower the threshold a bit. |
No description provided.