-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase sleep time in cache test and flush test output #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for possible coarse resolution of `bson_get_monotonic_time` on Windows
Flush stderr and stdout to avoid mixed output in logs.
To include newline.
Ignores formatting diffs. kms-message is not-yet formatted with current .clang-format.
kevinAlbs
changed the title
increase sleep time in cache test
increase sleep time in cache test and flush test output
Jan 8, 2025
eramongodb
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback; otherwise, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_test_encrypt_cache_expiration
.Verified by this patch build. The
debian-package-build*
task failures appear unrelated.Background & Motivation
The sleep time in
_test_encrypt_cache_expiration
is increased from 2ms to 10ms to address observed test failures on Windows tasks. I expect this is due to the coarse resolution ofbson_get_monotonic_time
on Windows: CDRIVER-4526.bson_get_montonic_time
is used to check the current time. Pending CDRIVER-4526, the test is updated to increase the sleep time to 20ms.TEST_PRINTF
andTEST_STDERR_PRINTF
macros are added to flush stdout and stderr. This is intended to fix mixed log output from stdout and stderr. Before:After:
Source files in
kms-message
are not currently formatted to the current.clang-format
. This PR does not attempt to reformat. I used the.clang-format
file from 8c9ed66 and ignored format-only diffs.