📝 DOP-4098 updates comment #931
Conversation
|
The URL for your feature branch webhook is https://bx7y7vb6xf.execute-api.us-east-2.amazonaws.com/prod/ |
| internalOnly: boolean; | ||
| [key: string]: any; | ||
| } | ||
|
|
||
| const internals: { [key: project]: ReposBranchesDocument } = {}; | ||
| export type ReposBranchesDocsetsDocument = ReposBranchesDocument & DocsetsDocument; |
There was a problem hiding this comment.
what is this new document type?
IIUC it contains url, prefix, bucket but also repoName, project, ...
There was a problem hiding this comment.
That is correct. The new document type is a combination of repos_branches and docsets. The following properties come from docsets now, which are prefix, bucket and URL.
There was a problem hiding this comment.
are we constructing a document with both of these properties? seeing that neither repos_branches or docsets collections has all of these properties defined. think we should be defining ReposBranchesDocument and DocsetsDocument separately, not combining them into one. (if connecting the two types, it should be that docsets have a repos property that is ReposBranchesDocument[] as in the data:
There was a problem hiding this comment.
We're aggregating the two together to have a flat access to all of the properties!
Part of me searching through all DOP codebases to ensure we are not pulling in
prefix,bucket, andURLfrom repo_branches, I stumbled across an outdated comment, and this PR updates that to reflect that we are now caching fromdocsetsThis PR has been updated for updating the Types as well to reflect the changes between
repos_branchesanddocsets