Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4359: add LanguagesBucket for s3 #1016

Merged
merged 2 commits into from
Mar 25, 2024
Merged

DOP-4359: add LanguagesBucket for s3 #1016

merged 2 commits into from
Mar 25, 2024

Conversation

mmeigs
Copy link
Contributor

@mmeigs mmeigs commented Mar 25, 2024

Stories/Links:

DOP-4359

Notes

This adds the necessary S3 Buckets for docs-languages

It also removes the intgr buckets that don't even exist in S3...?

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@mmeigs mmeigs requested review from branberry and rayangler March 25, 2024 19:02
Copy link

Your feature branch infrastructure has been deployed!

Your webhook URL is: https://ldk8ao8bnh.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build

For more information on how to use this endpoint, follow these instructions.

Copy link
Contributor

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, but wanted to flag one question

infrastructure/ecs-main/serverless.yml Show resolved Hide resolved
infrastructure/ecs-main/serverless.yml Show resolved Hide resolved
@mmeigs mmeigs requested a review from rayangler March 25, 2024 20:19
@mmeigs mmeigs merged commit 0480b71 into main Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants