Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4352: Set completion time for Netlify builds #1002

Merged
merged 5 commits into from
Feb 28, 2024
Merged

DOP-4352: Set completion time for Netlify builds #1002

merged 5 commits into from
Feb 28, 2024

Conversation

rayangler
Copy link
Contributor

@rayangler rayangler commented Feb 23, 2024

Stories/Links:

DOP-4352

Notes

  • The SnootyBuildComplete handler, which is used as a post-build webhook for Gatsby Cloud builds, has been updated to support a query string param called builder. We check if builder has a value of netlify (configured within the Netlify site itself), and update the data we currently need to. We intentionally do not want to notify a user for Netlify builds as they should silently run in parallel. By default, the webhook will assume it's a Gatsby Cloud build and it'll handle any data processing and notifications accordingly. (I thought about creating an entirely different webhook, but I wasn't sure if it was worth introducing having an entirely separate webhook just to have a slight difference. If there's a preference, please let me know!)
  • Added an await to the internal db update used in jobRepository.updateExecutionTime. Not having it would cause issues with the post-build webhook where the db connection would close before the update actually occurred.
  • For proof of concept, please go to pool_test.queue, filter by {_id: ObjectId('65dcf2d8c78dff69b2b7c74c')}, and see the new netlifyEndTime field added to the end of the document.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link

Your feature branch infrastructure has been deployed!

Your webhook URL is: https://ux3pfecibj.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build

For more information on how to use this endpoint, follow these instructions.

@rayangler rayangler marked this pull request as ready for review February 27, 2024 17:14
Copy link
Contributor

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rayangler rayangler merged commit 91761b1 into main Feb 28, 2024
9 checks passed
@rayangler rayangler deleted the DOP-4352 branch February 28, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants