DOP-4352: Set completion time for Netlify builds #1002
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4352
Notes
SnootyBuildComplete
handler, which is used as a post-build webhook for Gatsby Cloud builds, has been updated to support a query string param calledbuilder
. We check ifbuilder
has a value ofnetlify
(configured within the Netlify site itself), and update the data we currently need to. We intentionally do not want to notify a user for Netlify builds as they should silently run in parallel. By default, the webhook will assume it's a Gatsby Cloud build and it'll handle any data processing and notifications accordingly. (I thought about creating an entirely different webhook, but I wasn't sure if it was worth introducing having an entirely separate webhook just to have a slight difference. If there's a preference, please let me know!)await
to the internal db update used injobRepository.updateExecutionTime
. Not having it would cause issues with the post-build webhook where the db connection would close before the update actually occurred.pool_test.queue
, filter by{_id: ObjectId('65dcf2d8c78dff69b2b7c74c')}
, and see the newnetlifyEndTime
field added to the end of the document.README updates