Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-45284 DOCSP-45287 using the C++ driver from CMake and pkg-config #88

Merged
merged 7 commits into from
Dec 24, 2024
Merged

DOCSP-45284 DOCSP-45287 using the C++ driver from CMake and pkg-config #88

merged 7 commits into from
Dec 24, 2024

Conversation

rcsanchez97
Copy link
Collaborator

@rcsanchez97 rcsanchez97 commented Dec 3, 2024 •
edited by norareidy
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45284 and https://jira.mongodb.org/browse/DOCSP-45287
Staging - https://deploy-preview-88--docs-cpp.netlify.app/include-link/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for docs-cpp ready!

Name Link
🔨 Latest commit ad3f36b
🔍 Latest deploy log https://app.netlify.com/sites/docs-cpp/deploys/676b0171e848ee0009ca2ac3
😎 Deploy Preview https://deploy-preview-88--docs-cpp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rcsanchez97 rcsanchez97 requested a review from norareidy December 4, 2024 18:55
norareidy
norareidy requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! I left some suggestions, mostly related to the style guide (which you can read here).

source/include-link.txt Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
rcsanchez97 and others added 2 commits December 5, 2024 14:48
@rcsanchez97 @norareidy
Apply suggestions from code review
6f56e21 
Style guide-based suggestions from Nora

Co-authored-by: Nora Reidy <[email protected]>
@rcsanchez97
additional revisions
619543e
@rcsanchez97 rcsanchez97 requested a review from norareidy December 5, 2024 21:17
norareidy
norareidy requested changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I didn't realize I left these many comments, but let me know if you have questions about anything!

source/include-link.txt Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
@rcsanchez97
Copy link
Collaborator Author

oops I didn't realize I left these many comments, but let me know if you have questions about anything!

No worries. I'm working my way through them. I do appreciate all the feedback.

@rcsanchez97
Copy link
Collaborator Author

@norareidy in the two latest commits I have applied your suggested changes, and I also implemented the suggestion of breaking up the long sections of build output. I also created a troubleshooting sub-section.

norareidy
norareidy approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some final comments, thanks so much for your patience with this review!

source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
source/include-link.txt Outdated Show resolved Hide resolved
@rcsanchez97 rcsanchez97 merged commit 94b84ba into mongodb:master Dec 24, 2024
1 check failed
@rcsanchez97 rcsanchez97 deleted the docsp-45284 branch December 24, 2024 18:49
@rcsanchez97
Copy link
Collaborator Author

@norareidy Thanks to you as well! I really appreciate all of the guidance and suggestions, as well as your patience I have learned about our documentation processes. Now that this PR is merged, should I close the associated Jira tickets? Or will you handle that?

@norareidy
Copy link
Collaborator

@norareidy Thanks to you as well! I really appreciate all of the guidance and suggestions, as well as your patience I have learned about our documentation processes. Now that this PR is merged, should I close the associated Jira tickets? Or will you handle that?

Of course! I can close those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norareidy norareidy norareidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcsanchez97 @norareidy