Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-45567 - v4.0 Updates #82

Merged
merged 5 commits into from
Nov 22, 2024
Merged

DOCSP-45567 - v4.0 Updates #82

merged 5 commits into from
Nov 22, 2024

Conversation

mongoKart
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45567

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for docs-cpp ready!

Name Link
🔨 Latest commit 4548bb9
🔍 Latest deploy log https://app.netlify.com/sites/docs-cpp/deploys/6740ea3c76857a0008eaee19
😎 Deploy Preview https://deploy-preview-82--docs-cpp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

norareidy
norareidy approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mongoKart mongoKart requested a review from kevinAlbs November 22, 2024 14:53
kevinAlbs
kevinAlbs approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new libmongoc version table. LGTM with minor changes.

source/compatibility.txt Outdated Show resolved Hide resolved
source/includes/language-compatibility-table-cxx.rst Outdated Show resolved Hide resolved
source/includes/mongodb-compatibility-table-cxx.rst Outdated Show resolved Hide resolved
source/includes/libmongoc-compatibility-table-cxx.rst Outdated Show resolved Hide resolved
source/includes/libmongoc-compatibility-table-cxx.rst Outdated Show resolved Hide resolved
source/includes/libmongoc-compatibility-table-cxx.rst Outdated Show resolved Hide resolved
@mongoKart mongoKart merged commit 5e37556 into mongodb:master Nov 22, 2024
4 of 5 checks passed
@mongoKart mongoKart deleted the docsp-45567-v4.0 branch November 22, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norareidy norareidy norareidy approved these changes

@kevinAlbs kevinAlbs kevinAlbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mongoKart @kevinAlbs @norareidy