DOCSP-45311: Remove deprecated utf8 types #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-cpp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
approved these changes
Nov 21, 2024
source/upgrade.txt
Outdated
Comment on lines
88
to
89
| - ``get_utf8`` from the ``bsoncxx::v_noabi::document::element``, ``bsoncxx::v_noabi::array::element``, | ||
| and ``bsoncxx::v_noabi::types::bson_value::view`` classes. Instead, use ``get_string``. |
There was a problem hiding this comment.
Q: is this a type or a method?
There was a problem hiding this comment.
That one's a method! fixed
source/whats-new.txt
Outdated
| @@ -102,6 +102,17 @@ What's New in 4.0 | |||
| library equivalents. For context, see the :ref:`Build System Breaking Changes | |||
| <version-4.0-build-system-breaking>` admonition. | |||
|
|
|||
| - Removes the following deprecated ``utf8`` types that have ``string`` equivalents: | |||
There was a problem hiding this comment.
S: you could consider removing the full list from here and just linking to the upgrade guide for specific details and keep the list there?
norareidy
requested review from
kevinAlbs and
eramongodb
and removed request for
kevinAlbs
eramongodb
requested changes
Nov 22, 2024
eramongodb
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45311
Staging - https://deploy-preview-78--docs-cpp.netlify.app/upgrade/#version-4.0
Self-Review Checklist