Code example generator [LG-2954, LG-2950, LG-2951] #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSonOfThomp
changed the title
bruugey
reviewed
Apr 21, 2023
bruugey
reviewed
Apr 21, 2023
bruugey
reviewed
Apr 21, 2023
bruugey
reviewed
Apr 21, 2023
| let isRootSet = false; | ||
| let componentRoot: ReactElement<any> = renderedStory; | ||
|
|
||
| // @ts-expect-error - prepass callback args are incorrectly typed. Need to explicitly re-type them |
There was a problem hiding this comment.
is there an open issue on their side that we can reference here?
There was a problem hiding this comment.
There is now FormidableLabs/react-ssr-prepass#86
There was a problem hiding this comment.
Though the last commit to that repo was over a year ago, so no guarantees it gets in. I could try and find another library that does the same, but in my research, the other options were even more out-of-date.
(another option would be to port over the code and maintain it ourselves, but that doesn't feel right to me)
bruugey
reviewed
Apr 21, 2023
bruugey
reviewed
Apr 24, 2023
bruugey
reviewed
Apr 25, 2023
bruugey
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traverses the rendered example component in the ReactTree to find the relevant component, then generates the JSX string from that component.
To Test:
Link this branch: mongodb/leafygreen-ui#1700
Rebuild packages (
yarn build) and docs (yarn docs:tsdoc)