🧹 Try to update os provider to latest #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #149 Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
christian/fix_149
branch
from
728c7c4 to
b1bbf3b
Compare
imilchev
reviewed
Nov 14, 2023
provisioner/provisioner.go
Outdated
| } | ||
| outdated := false | ||
| for _, provider := range allProviders { | ||
| if provider.Name == "os" { |
There was a problem hiding this comment.
is it just the os provider that we are interested in? is it possible that other providers are also used by the packer plugin? We do have types in OS that are defined in network, for example... Shouldn't this be just the same function as the one updating the providers in cnspec?
There was a problem hiding this comment.
The network provider is a good catch. Didn't think about this one. Yes, then we can use the same code as for the cnspec PR.
Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
imilchev
approved these changes
Nov 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149