WIP: Add LOINC PART mappings #35
Conversation
|
@matentzn please give another round of feedback and help with the open issues. thanks a lot |
There was a problem hiding this comment.
Awesome THANKS!
Here my review
- All SSSOM files should be directly in mappings/ not sub directories.
- Filenames are important, so I would prefer 1 and 2 over seb and tim, e.g
loinc2chebi_2.sssom.tsv. Use the filenames that correspond the the "mapping_set_id" suggestions I made. - Add link to issue_tracker to all of them. I made an example of this in loinc2uberon.sssom.tsv
- Add author_id (your orcid) to all of them
You can apply all my change suggestions at once by clicking on "Ass suggestion to batch" on all of them, and then "commit changes".
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
Co-authored-by: Nico Matentzoglu <[email protected]>
…u let this pass now
|
I hope it looks better now |
|
@drseb can you confirm: You personally curated all of these mapping sets manually? Can you write two sentences here (in a comment on the PR) on how you created the mapping sets exactly (methodology), and what mapping rules you applied (using exact in case where units were mentioned, etc). |
|
All mappings except |
| # license: https://github.com/mapping-commons/mapping-commons.github.io/blob/main/docs/original_license_applies.md | ||
| # mapping_date: '2022-02-23' | ||
| # mapping_set_id: http://w3id.org/mapping_commons/monarch/loinc2chebi_1.sssom.tsv | ||
| # issue_tracker: https://github.com/monarch-initiative/monarch-mapping-commons/issues |
There was a problem hiding this comment.
Missing author_id and creator_id. What is the provenance for this one?
|
Can you describe in a bit more detail the mapping rules you used, for example:
So so the statement would be correct that all mappings aside from Tims were manually reviewed by you right? |
@drseb this is work in progress, I will give you some rounds of feedback on these.
Dont change the skos:exactMatches yet.