Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli, checker): add key for local triggers ids #967

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

Tetrergeru
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (ae71a96) 68.57% compared to head (94e65d0) 68.20%.

❗ Current head 94e65d0 differs from pull request most recent head 9607241. Consider uploading reports for the commit 9607241 to get more accurate results

Files Patch % Lines
cmd/cli/from_2.9_to_2.10.go 0.00% 44 Missing ⚠️
cmd/cli/main.go 0.00% 35 Missing ⚠️
cmd/cli/errors.go 0.00% 5 Missing ⚠️
cmd/cli/cluster.go 0.00% 4 Missing ⚠️
database/redis/trigger.go 70.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
- Coverage   68.57%   68.20%   -0.38%     
==========================================
  Files         206      208       +2     
  Lines       11660    11731      +71     
==========================================
+ Hits         7996     8001       +5     
- Misses       3185     3251      +66     
  Partials      479      479              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tetrergeru Tetrergeru marked this pull request as ready for review November 16, 2023 08:41
@Tetrergeru Tetrergeru requested a review from a team as a code owner November 16, 2023 08:41
@Tetrergeru
Copy link
Member Author

/build

@Tetrergeru
Copy link
Member Author

/build

kissken
kissken previously approved these changes Nov 16, 2023
@Tetrergeru Tetrergeru merged commit f31ac9d into master Nov 22, 2023
5 checks passed
@Tetrergeru Tetrergeru deleted the feature/add-key-for-local-triggers branch November 22, 2023 09:15
Copy link

Build and push Docker images with tag: 2023-11-22.f31ac9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants