refactor(api, db): team validation #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2024
AleksandrMatsko
changed the title
kissken
reviewed
Nov 13, 2024
Tetrergeru
reviewed
Nov 19, 2024
Tetrergeru
reviewed
Nov 19, 2024
Tetrergeru
previously approved these changes
Nov 25, 2024
kissken
previously approved these changes
Nov 26, 2024
* feat: migrations for team validation * feat: write log than team will be renamed * refactor: logging then renaming teams, add timeout between modifying teams and committing changes
AleksandrMatsko
dismissed stale reviews from kissken and Tetrergeru
via
49c69a6
Tetrergeru
approved these changes
Nov 26, 2024
|
Build and push Docker images with tag: 2024-11-26.520c968 |
1 similar comment
|
Build and push Docker images with tag: 2024-11-26.520c968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Before this PR it was possible to create teams with same names.
This PR forbids create/update of team with name which is alredy belongs to other team (no matter case, so names "Team name" and "Team Name" are the same then checking name existence).
Also:
LimitsConfig.Note: Database schema is changed a bit. Added separate key (
"moira-teams-by-names") to store team IDs by team names. Than saving/deleting team this key is also updated. Migrations are in #1124 .