fix(checker): Don't rewrite error while compare trigger states (#1035)

moira-alert · Jun 20, 2024 · 78a7a88 · 78a7a88
1 parent 17a4941
commit 78a7a88
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/checker/check.go b/checker/check.go
@@ -138,8 +138,17 @@ func (triggerChecker *TriggerChecker) handleFetchError(checkData moira.CheckData
 		if timeSinceLastSuccessfulCheck >= triggerChecker.ttl {
 			checkData.State = moira.StateEXCEPTION
 			checkData.Message = fmt.Sprintf("Remote server unavailable. Trigger is not checked for %d seconds", timeSinceLastSuccessfulCheck)
-			checkData, err = triggerChecker.compareTriggerStates(checkData)
+
+			var comparingErr error
+			checkData, comparingErr = triggerChecker.compareTriggerStates(checkData)
+			if comparingErr != nil {
+				triggerChecker.logger.Error().
+					Error(comparingErr).
+					String(moira.LogFieldNameTriggerID, triggerChecker.triggerID).
+					Msg("cannot compare trigger states")
+			}
 		}
+
 		logTriggerCheckException(triggerChecker.logger, triggerChecker.triggerID, err)
 	case local.ErrUnknownFunction, local.ErrEvalExpr:
 		checkData.State = moira.StateEXCEPTION